Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault when encountering an error in in-context parsing #643

Closed
flavorjones opened this issue Mar 28, 2012 · 4 comments
Closed

Segfault when encountering an error in in-context parsing #643

flavorjones opened this issue Mar 28, 2012 · 4 comments
Labels
topic/memory Segfaults, memory leaks, valgrind testing, etc.

Comments

@flavorjones
Copy link
Member

From rosco [email protected] on the nokogiri-talk mailing list:

require 'nokogiri'
require 'open-uri'

url = 'http://xiandaipump.en.made-in-china.com/product/DbpngKCrEsWB/China-Industrial-Pump-CDLF-.html'
html = open(url)
doc = Nokogiri::HTML html
doc.css('a').each { |anchor| anchor.replace anchor.inner_html }

Segfault occurs at xml_node.c:1309 and appears to be related to f5bf295

@flavorjones
Copy link
Member Author

@tenderlove, can you provide some context around f5bf295? Y U NO WRITE TEST!?

@tenderlove
Copy link
Member

😢 It was to stop valgrind errors. I don't know how to test those! :-P

@flavorjones
Copy link
Member Author

OK, I'm on it.

@flavorjones
Copy link
Member Author

I've reproduced this with a small test case. On it!

flavorjones added a commit that referenced this issue Apr 27, 2012
@flavorjones flavorjones added the topic/memory Segfaults, memory leaks, valgrind testing, etc. label Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/memory Segfaults, memory leaks, valgrind testing, etc.
Projects
None yet
Development

No branches or pull requests

2 participants