Use body as the context element for Document#fragment
#2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns with the behavior for the HTML 4 parser. Fixes: #2551
also make the tests a bit more self-explanatory
|
I rebased and added a bit of documentation to Should go green, I'll merge after that. |
flavorjones
reviewed
Jul 19, 2022
| # Nokogiri::HTML5::DocumentFragment. This object's children will be empty if `markup` is not passed, is empty, or is `nil`. | ||
| # | ||
| def fragment(markup = nil) | ||
| DocumentFragment.new(self, markup) |
There was a problem hiding this comment.
Note that I changed this line to not pass in the third argument, rather than pass in an explicit nil.
flavorjones
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Fixes: #2551
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
It changes the C HTML5 visible behavior (but not implementation) to match the C HTML4 implementation. I don't know what the Java implementation does.