-
-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: try UCRT for windows ruby-head builds #2272
Conversation
@larskanis This looks like it might be a genuine failure on UCRT?
|
The failure happens when calling the XLST function |
@larskanis That's interesting! Looking at #if defined(HAVE_TIME_H) \
&& (defined(HAVE_LOCALTIME) || defined(HAVE_LOCALTIME_R)) \
&& (defined(HAVE_GMTIME) || defined(HAVE_GMTIME_R)) \
&& defined(HAVE_TIME)
#define WITH_TIME
#endif I'll also note that it's fine when Nokogiri compiles it ( Anything I can do to help? |
Also: I'd be fine with not fixing this. For example, when using a version of libxml2 that does not have iconv support compiled in, we skip the tests and expose that configuration as part of VERSION_INFO. |
WDYT of the following solution:
Then we can either rewrite the failing test to not depend on date/time functionality, and/or conditionally run tests based on the value of the constant. |
I opened a PR on Mingw-packages addressing the date/time issue: msys2/MINGW-packages#8957 |
@larskanis In the meantime, I have a commit on this PR to detect whether libxslt is built with date-time functionality, and skip the assertion if not. |
973b813
to
a7fde5c
Compare
see #2268 for context Co-authored-by: MSP-Greg <[email protected]>
- expose this compile-time config as Nokogiri::VERSION_INFO["libxslt"]["datetime_enabled"] - skip the assertion that depends on this behavior
a7fde5c
to
5bb0bcb
Compare
The latest MSYS2 package |
@larskanis yup! looks good in this build: https://github.com/sparklemotion/nokogiri/runs/2873137424#step:7:35 |
What problem is this PR intended to solve?
The 3.1.0.dev windows ruby installer uses UCRT, see #2268 for context. This gives Nokogiri and @larskanis a feedback loop.