Clean up deprecated calls into JRuby #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deprecations here in JRuby are at least two years old. Some of these changes are not backward-compatible with JRuby versions prior to that, but those JRuby versions are no longer supported. Summary of changes: * Use RubyException.toThrowable to construct a Throwable wrapper for an exception, rather than constructing RaiseException directly. The new mechanism allows exceptions to override what type of Java throwable they represent. This change is not compatible with JRuby versions prior to 9.2. * Avoid the long-deprecated (pre-9k) NativeException by raising RuntimeError for some unexpected exceptions instead of using RaiseException.createNativeRaiseException. The NativeException class has been unsupported for many years in JRuby, and these are better represented as RuntimeError. * Deprecate to_s19 override and flip delegation to to_s. All of the "19" methods were deprecated for JRuby 9k, and many have since been removed. The delegation should now prefer the non-19 name and avoid the 19 version.
|
Code Climate has analyzed commit de8c32d and detected 0 issues on this pull request. View more on Code Climate. |
headius
added a commit
to headius/jruby
that referenced
this pull request
Apr 26, 2020
This was still being used by Nokogiri as recently as Feb 2019, so we can't delete it for some time. This usage was removed in the middle of the 9.2 series by @jvshahid in sparklemotion/nokogiri#1874. See sparklemotion/nokogiri#2027 for recent work to remove deprecated calls from Nokogiri.
|
❌ Build nokogiri 1.0.592 failed (commit 6804c7e4d2 by @headius) |
|
The failed build is for ruby-head... I assume that's not my fault. |
kares
reviewed
Apr 27, 2020
Co-authored-by: Karol Bucek <[email protected]>
|
I believe this is ready after the change by @kares. |
|
✅ Build nokogiri 1.0.679 completed (commit eaa04e6a7c by @headius) |
|
Great, thank you both! Will merge this onto master for release in the next v1.11.0 release candidate. @headius Please let me know if you want this pulled into a v1.10.x (stable) release; I'm assuming it's OK to just ship in a v1.11.0 final later this year. |
|
@flavorjones Yeah there's no rush on this. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all deprecation warnings from the Java extension by using newer preferred APIs in JRuby.
The bulk of changes are to use
RubyException.toThrowable()to construct a Java throwable for a Ruby exception, rather than the deprecatedRaiseExceptionconstructor. This change is the likely the most controversial since it breaks compatibility with JRuby versions older than 9.2.The other changes are to use RuntimeError instead of NativeException for raising unexpected Java XML errors, and to move away from overriding the old
to_s19form from JRuby 1.7.