Fix a couple of issues on OpenBSD #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the base compiler or compiler specified by CC is clang, then don't require egcc. Add /usr/local/include as an include directory when compiling. With these changes, the current release of OpenBSD should be able to install nokogiri using gem install.
|
Looks good, PR pipeline went green. Merging! Are there any changes to the installation tutorial that we should make as a result? |
|
For the install tutorial, where it mentions FreeBSD/OpenBSD, maybe just change |
flavorjones
added a commit
to sparklemotion/nokogiri.org-tutorials
that referenced
this pull request
Nov 13, 2017
|
Docs change done and pushed to http://www.nokogiri.org/tutorials/installing_nokogiri.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the base compiler or compiler specified by CC is clang, then
don't require egcc.
Add /usr/local/include as an include directory when compiling.
With these changes, the current release of OpenBSD should be
able to install nokogiri using gem install without
--use-system-libraries.