Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clamp results of NodeSet#first to length of NodeSet #1650

Merged
merged 1 commit into from
Jul 22, 2017

Conversation

Derenge
Copy link
Contributor

@Derenge Derenge commented Jun 13, 2017

NodeSet#first did not perform the same as Enumberable#first

An example from ruby doc being:

%w[foo bar baz].first(10) #=> ["foo", "bar", "baz"]

What was expected:

Nokogiri::HTML('').css('a').first(3)
[#<Nokogiri::XML::Element:0x3fc3dfd5f1c8 name="a">, #<Nokogiri::XML::Element:0x3fc3dfd5f1b4 name="a">]

What was received:

Nokogiri::HTML('').css('a').first(3)
[#<Nokogiri::XML::Element:0x3fc3dfd5f1c8 name="a">, #<Nokogiri::XML::Element:0x3fc3dfd5f1b4 name="a">, nil]

@Derenge
Copy link
Contributor Author

Derenge commented Jun 14, 2017

I'm unsure how to address the failing concourse build

@flavorjones
Copy link
Member

@Derenge see #1654 for updates on debugging the failed build ... working on it.

@flavorjones
Copy link
Member

@Derenge if you'd like to rebase off of 451d598 or later, the Concourse CI build will re-run and should pass. Sorry for the inconvenience.

@Derenge
Copy link
Contributor Author

Derenge commented Jul 20, 2017

Is there anything I need to do to move this along?

@flavorjones
Copy link
Member

Sorry for the delay, I've not spent much time on OSS lately. Merging now ...

@flavorjones flavorjones merged commit c437ab4 into sparklemotion:master Jul 22, 2017
@flavorjones
Copy link
Member

Merged! Thank you so much for contributing, and for your patience. I've thanked you in the CHANGELOG.

@flavorjones flavorjones added this to the 1.8.1 milestone Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants