Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont assume rubygems is loaded before using gem command #1411

Merged
merged 1 commit into from
Jan 19, 2016

Conversation

JonRowe
Copy link
Contributor

@JonRowe JonRowe commented Jan 18, 2016

This is a clarification of why #1393 was needed. It's not that rspec-rails fails without this, but any installation where rubygems is not available (we deliberately do this on rspec's suites for speed reasons). It would be better to ensure rubygems is available before using it's components.

larskanis added a commit that referenced this pull request Jan 19, 2016
Dont assume rubygems is loaded before using gem command.

This fixes issue #1393 .
@larskanis larskanis merged commit d0ad22f into sparklemotion:master Jan 19, 2016
@larskanis
Copy link
Member

@JonRowe Thanks, you're right - I'll add this to the documentation of mini_portile as well.

@JonRowe JonRowe deleted the dont_assume_rubygems branch January 19, 2016 10:39
@JonRowe
Copy link
Contributor Author

JonRowe commented Jan 19, 2016

@larskanis it's not the mini_portile usage thats the issue it's the gem method

@JonRowe
Copy link
Contributor Author

JonRowe commented Jan 19, 2016

but thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants