-
-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patching config.guess allows nokogiri installation on machines based on ppc64le architecture. #1326
Patching config.guess allows nokogiri installation on machines based on ppc64le architecture. #1326
Conversation
When this patch is applied it updates config.guess file inside the tem dir where libxslt gets extracted before installation.
Ah - I somehow missed this PR. Will take a look! |
This looks good to me. The Tests run successfully on Linux, on OS X and on Windows, when merged to master. |
That's good to hear! You guys let me know if there's anything else that I can do. Do you think it's possible that this patch makes it into 1.6.7 final? |
@flavorjones This PR patches |
Following @larskanis idea, I've created PR #1352 that updates both libxslt and libxml2 config.guess files to the latest version IMHO this would be the most consistent approach, but in any case you can now choose between PR #1326 and PR #1352 and use the one you think it's more appropiate. Hope you don't mind that I've opened 2 PR's for 2 different ways to solve the same problem :) |
@hernan-erasmo Thanks for this. I think I'd like to get this (or your other PR) into 1.6.7, since it seems to be turning into an "installation improvement" release. ;) |
Confirmed the contents of config.guess are what we expect, post-patch. This isn't optimal, as it's persisting the difference between libxml2's current file and the latest from the @hernan-erasmo: Have you sent a patch upstream to libxml2/libxslt to update their config.guess? If not, I'd like to ask that you do. Merged into master now. Will be in 1.6.7.rc4. |
When this patch is applied, it updates config.guess file inside the temp dir where libxslt gets extracted before installation.