Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching config.guess allows nokogiri installation on machines based on ppc64le architecture. #1326

Conversation

hernan-erasmo
Copy link
Contributor

When this patch is applied, it updates config.guess file inside the temp dir where libxslt gets extracted before installation.

When this patch is applied it updates config.guess file inside the tem dir where libxslt gets extracted before installation.
@hernan-erasmo hernan-erasmo changed the title Patching config.guess resolves sparklemotion/nokogiri#1280 Patching config.guess allows nokogiri installation on machines based on ppc64le architecture. Aug 20, 2015
@flavorjones
Copy link
Member

Ah - I somehow missed this PR. Will take a look!

@larskanis
Copy link
Member

This looks good to me. The config.guess of the last libxslt release is ancient and no newer version is available in the git repo. So I think patching like this is OK.

Tests run successfully on Linux, on OS X and on Windows, when merged to master.

@hernan-erasmo
Copy link
Contributor Author

That's good to hear! You guys let me know if there's anything else that I can do.

Do you think it's possible that this patch makes it into 1.6.7 final?

@larskanis
Copy link
Member

@flavorjones This PR patches config.guess to the version of 2015-07-03 but libxml2 uses an older version of 2013-06-10 (the latest version is 2015-09-14 currently). What is you opinion - should we patch libxslt to 2013-06-10 or patch libxml2 to 2015-07-03 as well or merge this and use two different versions of config.guess in libxml2 and libxslt?

@hernan-erasmo
Copy link
Contributor Author

(@flavorjones)

Following @larskanis idea, I've created PR #1352 that updates both libxslt and libxml2 config.guess files to the latest version

IMHO this would be the most consistent approach, but in any case you can now choose between PR #1326 and PR #1352 and use the one you think it's more appropiate.

Hope you don't mind that I've opened 2 PR's for 2 different ways to solve the same problem :)

@flavorjones
Copy link
Member

@hernan-erasmo Thanks for this. I think I'd like to get this (or your other PR) into 1.6.7, since it seems to be turning into an "installation improvement" release. ;)

@flavorjones flavorjones added this to the 1.6.7 milestone Sep 18, 2015
@flavorjones
Copy link
Member

Confirmed the contents of config.guess are what we expect, post-patch.

This isn't optimal, as it's persisting the difference between libxml2's current file and the latest from the config project, but it's good enough for now. When it breaks (and it will, whenever libxml2/libxslt update their config), we'll likely change this implementation to simply copy in the latest config.guess rather than try to patch what's there.

@hernan-erasmo: Have you sent a patch upstream to libxml2/libxslt to update their config.guess? If not, I'd like to ask that you do.

Merged into master now. Will be in 1.6.7.rc4.

flavorjones added a commit that referenced this pull request Nov 17, 2015
Please note these files are related to #1326 where I've registered my
opinion that these patch files are not the right solution, and we should
fix it the right way when these patches (eventually) fail.

#1326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants