Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

has_field? and has_value? should return true/false #501

Merged
merged 2 commits into from
Jun 2, 2018
Merged

has_field? and has_value? should return true/false #501

merged 2 commits into from
Jun 2, 2018

Conversation

mamantoha
Copy link
Contributor

No description provided.

@mamantoha
Copy link
Contributor Author

mamantoha commented Oct 25, 2017 •
edited
Loading

Spec fixed according to this commit in Ruby ruby/ruby@427f5b5

@knu knu merged commit 564a9e1 into sparklemotion:master Jun 2, 2018
knu added a commit that referenced this pull request Jun 2, 2018
@knu
Merge PR #501 into has_value-boolean
41473b4
@knu
Copy link
Member

knu commented Jun 2, 2018

You could use any? instead of !!find, so I modified has_field? along with has_value? accordingly.

@knu
Copy link
Member

knu commented Jun 2, 2018

Thanks!

@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamantoha @knu