Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with updating Sparkle 2.1.0 to 2.3.2 #2331

Closed
chulup opened this issue Mar 1, 2023 · 4 comments
Closed

Problem with updating Sparkle 2.1.0 to 2.3.2 #2331

chulup opened this issue Mar 1, 2023 · 4 comments
Labels
2.x Sparkle 2.0

Comments

@chulup
Copy link

chulup commented Mar 1, 2023

Description of the problem

My app used Sparkle 2.1.0 and then was tested with 2.2.2 without any issues.
Now I'm trying to update to 2.3.2 (building locally and testing the update process) which leads to an error: "An error occurred in retrieving update information. Please try again later."

I had to change on line in my SparkleUserDriver implementation before compilation was successfull:

-- (void)showInstallingUpdateWithApplicationTerminated:
-    (BOOL)applicationTerminated {
+- (void)showInstallingUpdateWithApplicationTerminated:(BOOL)applicationTerminated
+                          retryTerminatingApplication:(void (^)(void))retryTerminatingApplication{

Do you use Sandboxing in your app?

No

Version of Sparkle.framework in the latest version of your app

2.3.2

Version of Sparkle.framework in the old version of app that your users have (or N/A)

2.1.0 and tested locally with 2.2.2

Sparkle's output from Console.app

(un-localized here):

error	20:20:15.250138+0300	 <app>	Connection to update downloader was invalidated
error	20:20:15.250240+0300  <app>	Encountered download feed error: Error Domain=SUSparkleErrorDomain Code=2001 "An error occurred in retrieving update information. Please try again later." UserInfo={NSLocalizedDescription=An error occurred in retrieving update information. Please try again later.}

Steps to reproduce the behavior

Compile application with Sparkle 2.1.0 or 2.2.2 and update goes successfully.
Recompile with Sparkle 2.3.2 and that error is returned to me.

@chulup chulup added the 2.x Sparkle 2.0 label Mar 1, 2023
@zorgiepoo
Copy link
Member

zorgiepoo commented Mar 2, 2023

Odd, I don't think 2.3.x changed much for retrieving the appcast feed except for #2317

Do you use the downloader XPC Service? Also, does your app need to use the downloader XPC Service?

2.2 renamed the XPC Services so I wonder if anything odd caching-wise is coming about from that. Does the issue reproduce if you move the app somewhere else or reboot your machine, or if you don't run the app in Xcode? Other thing to see is if issue reproduces with 2.3.0 or 2.3.1.

(note the user driver change is expected).

@zorgiepoo
Copy link
Member

zorgiepoo commented Mar 2, 2023

Ah, also, if you are using the Downloader XPC Service, check the Console logs for the "Downloader" process or if it has any crashes.

I can't reproduce your problem.

@zorgiepoo
Copy link
Member

zorgiepoo commented Mar 9, 2023

@chulup any new info here? (otherwise will close)

@chulup
Copy link
Author

chulup commented Mar 9, 2023

@zorgiepoo
Turned out the downloader service has been enabled few months ago and it worked fine for 2.1.0 and 2.2.2. I just disabled it and the problem went away.

Thank you for your help!

@chulup chulup closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Sparkle 2.0
Projects
None yet
Development

No branches or pull requests

2 participants