Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set 'ignore RX', set contrast, set RGB without writing EEPROM #35

Open
JamesB7 opened this issue May 14, 2021 · 2 comments
Open

Comments

@JamesB7
Copy link

JamesB7 commented May 14, 2021

In my application, I do not need the device to write to EEPROM -- really, for anything. I expect to be streaming 'set RGB' quickly to do fades between colors (for example, fade white to red when an error occurs, fade back afterward), and this will certainly wear the EEPROM out if it writes it.

It would be very helpful to have a pair of commands to disable/re-enable EEPROM writes when changing settings. (These would be sent during initialization and so should not themselves be saved.)

Thank you!

James

@JamesB7
Copy link
Author

JamesB7 commented May 14, 2021

Would you accept a patch for this if I were to write one?
I'd do it by adding commands to the pipe command set -- there's plenty of room there, and I can do this simply.
(A command of this sort would also protect the device against bricking. If bits flip, and it writes a new I2C address to EEPROM, for example, no more screen. If I put the device in a 'EEPROM write disable' state most of the time, odds are, end users will not run into a problem.)

@nseidle
Copy link
Member

nseidle commented May 14, 2021

Yes please, PRs are welcome. Our greatest priority is to maintain reverse compatibility so as long as it's new commands, we should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants