Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose request/connection info #441

Merged
merged 7 commits into from
Mar 19, 2023
Merged

feat: expose request/connection info #441

merged 7 commits into from
Mar 19, 2023

Conversation

r3b-fish
Copy link
Contributor

@r3b-fish r3b-fish commented Mar 10, 2023 •
edited
Loading

Description
Implemented access of request information: method, path, host:port and protocol.
In generally, it needs to implement more complicated logic in middlewares.

@r3b-fish r3b-fish force-pushed the feature/add-original-uri branch 6 times, most recently from 2c230b4 to 74741bc Compare March 11, 2023 04:14
@sansyrox
Copy link
Member

Hi @r3b-fish 👋

Thank you for the PR 😊 the pr looks nice from the first glance but I will give it a deeper look tonight 😊

sansyrox
sansyrox reviewed Mar 11, 2023
View reviewed changes
src/types.rs Outdated Show resolved Hide resolved
@r3b-fish r3b-fish force-pushed the feature/add-original-uri branch 2 times, most recently from 1be4813 to 863afbb Compare March 12, 2023 00:26
@r3b-fish r3b-fish force-pushed the feature/add-original-uri branch from 143cd83 to 1242187 Compare March 12, 2023 00:27
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 12, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #441 feature/add-original-uri (120e453) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 68 untouched benchmarks

🆕 4 new benchmarks
⁉️ 0 dropped benchmarks

Benchmarks breakdown

Benchmark main feature/add-original-uri Change
🆕 test_http_request_info_get[/sync/http/param-expected_json0] N/A 31.4 ms N/A
🆕 test_http_request_info_get[/async/http/param-expected_json1] N/A 31.4 ms N/A
🆕 test_param_suffix[sync] N/A 61.3 ms N/A
🆕 test_param_suffix[async] N/A 61.3 ms N/A

@r3b-fish r3b-fish force-pushed the feature/add-original-uri branch from e90a5dc to 09cd237 Compare March 12, 2023 03:31
@r3b-fish r3b-fish changed the title Expose additional info about request Expose connection info Mar 12, 2023
@r3b-fish r3b-fish changed the title Expose connection info Expose request/connection info Mar 12, 2023
@r3b-fish r3b-fish requested a review from sansyrox March 12, 2023 10:13
@r3b-fish r3b-fish changed the title Expose request/connection info feat: expose request/connection info Mar 15, 2023
sansyrox
sansyrox reviewed Mar 15, 2023
View reviewed changes
src/types.rs Outdated Show resolved Hide resolved
sansyrox
sansyrox reviewed Mar 15, 2023
View reviewed changes
src/types.rs Outdated Show resolved Hide resolved
@r3b-fish r3b-fish requested a review from sansyrox March 16, 2023 03:52
@r3b-fish r3b-fish force-pushed the feature/add-original-uri branch from 9bd597e to 120e453 Compare March 18, 2023 09:40
sansyrox
sansyrox approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🔥

LGTM 😄

@sansyrox sansyrox merged commit a96db3a into sparckles:main Mar 19, 2023
@r3b-fish r3b-fish deleted the feature/add-original-uri branch June 16, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sansyrox sansyrox sansyrox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r3b-fish @sansyrox