Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better way to compare type #421

Merged
merged 1 commit into from
Feb 19, 2023
Merged

better way to compare type #421

merged 1 commit into from
Feb 19, 2023

Conversation

jmishra01
Copy link
Contributor

Instead of checking type of variable using type method, we can use isinstance method to check.

This PR fixes #

@netlify
Copy link

netlify bot commented Feb 19, 2023 •
edited
Loading

✅ Deploy Preview for robyn canceled.

Name Link
🔨 Latest commit 938b3fb
🔍 Latest deploy log https://app.netlify.com/sites/robyn/deploys/63f210983bec4d000830de5a

sansyrox
sansyrox approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @jmishra01 . LGTM 😄 ❇️

@sansyrox sansyrox merged commit 505b012 into sparckles:main Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sansyrox sansyrox sansyrox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmishra01 @sansyrox