feat: Add view controllers

[mikaeelghr]

Description
Add the ability to add views.

usage:

from robyn import Robyn

app = Robyn(__file__)


@app.view("/")
def view():
    def get():
        return "Hello, world!"
    def post():
        return "Hello, world!"

app.start()

This PR fixes #221

[netlify]

✅ Deploy Preview for robyn canceled.

Name	Link
🔨 Latest commit	4b5dd5b
🔍 Latest deploy log	https://app.netlify.com/sites/robyn/deploys/63f284c7e5a2e00008f3003d

[sansyrox]

Thanks for the PRs @mikaeelghr . It was amazing waking up to these happy surprises 😄

I will try to review your PRs over the course of the day.

[sansyrox]

Hey @mikaeelghr ,

Thanks for the PR. I have a few suggestions for the PR. Can you write some integration tests for your code?

Second instead of creating an @app.view decorator, I wanted to add a function like app.add_view("/", view). The rationale behind that is that if a developer wants to use the decorator syntax, they will use the @get, @post, etc.

But if they want to organize their code in different files or responsibilities, they should use the view syntax and they can include the function from the module.

[sansyrox]

@mikaeelghr , I have added a few tests. Everything else looks great!

[mikaeelghr]

Thanks for the follow up @sansyrox, I was very busy this week and I couldn't add the tests.

One more thing, based on your comment, shouldn't we delete the view function on the robyn/__init__.py?

[sansyrox]

Thanks for the follow up @sansyrox, I was very busy this week and I couldn't add the tests.

No worries @mikaeelghr 😄

I am actually working a lot with views today. And I realized that having this versatility(the @app.view decorator) is a nice touch. Great work! 😄

I will be pushing an update shortly

[AntoineRR]

Great job! 😄 I added a few small suggestions. One last here: I would put all tests related to views in the same file, be they sync or async. This is what's done for the other features so I think it makes more sense.

[sansyrox]

@AntoineRR , everything is resolved now. Thank you for the review 😄

Thanks for the great work again @mikaeelghr 😄

[AntoineRR]

Thanks for the fixes! One last thing @sansyrox, can't we merge the integration_tests/views/async_view.py and integration_tests/views/test_view.py files together? Or at least rename test_view.py to sync_view.py?

[sansyrox]

@AntoineRR ,

can't we merge the integration_tests/views/async_view.py and integration_tests/views/test_view.py files together?

We can but I wanted to suggest one view per file(like react) for better organization of the code.

Or at least rename test_view.py to sync_view.py?

Done! 😄

[domingues]

@mikaeelghr @sansyrox Genuine question, why not use a simple class vs doing code introspection to extract the inner functions? Can't see in each way this is a better approach.

[sansyrox]

Hi @domingues 👋

We don't want to choose function base approach over class based approach. I just like to structure my code in closures sometimes and not having the ability to do that anywhere else was annoying .

We just haven't got around to implementing class-based views as of yet. 😅