fix: Fix Windows tests #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for robyn canceled.
|
sansyrox
force-pushed
the
fix/windows-tests
branch
from
ff9cb16 to
a1d6bdd
Compare
|
These are great suggestions @AntoineRR 😄 I will implement them tomorrow haven't slept in two days haha 🤣 |
sansyrox
force-pushed
the
fix/windows-tests
branch
2 times, most recently
from
707cc30 to
35ed50b
Compare
get conditional global hosts as windows does not allow 0.0.0.0 host
sansyrox
force-pushed
the
fix/windows-tests
branch
from
35ed50b to
a68d94b
Compare
|
@AntoineRR , all done! 😄 |
AntoineRR
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get conditional global hosts as windows does not allow 0.0.0.0 host
Description
This PR fixes #372
Fixes test on windows