chore: fix requirements files and update packages #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for robyn canceled.
|
AntoineRR
force-pushed
the
requirements-fix
branch
from
ffa419c to
54fc44e
Compare
sansyrox
reviewed
Feb 4, 2023
| @@ -28,7 +28,7 @@ jobs: | |||
| run: rustup target add aarch64-apple-darwin | |||
| - name: Setup Rust part of the project | |||
| run: | | |||
| maturin build -i python --universal2 --out dist --no-sdist | |||
There was a problem hiding this comment.
Why do we want to upload the sdist files?
There was a problem hiding this comment.
This is because of the new version of maturin, the no-sdist flag disappeared in v0.13.
See https://www.maturin.rs/migration.html#from-012-to-013:
maturin 0.13 replaced --no-sdist with the new --sdist option in maturin build command, source distributions are now only built when --sdist is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some requirements were not in the right requirements file. Also I updated the packages.