Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix robyn installation in test CI #383

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

AntoineRR
Copy link
Collaborator

Description

I noticed with my latest PRs that the CI had some issues after my updates... It was downloading the robyn package from Pypi instead of installing it from the whl built locally. Also the if condition for installing the macos rust target wasn't working.
This fixes all those issues! (had to fix the watchdog version for this as we want to have the same version installed with the requirements and required by robyn)

@netlify
Copy link

netlify bot commented Jan 29, 2023

Deploy Preview for robyn canceled.

Name Link
🔨 Latest commit 1c1ba9f
🔍 Latest deploy log https://app.netlify.com/sites/robyn/deploys/63d6ee16e557b1000928fdea

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@sansyrox sansyrox merged commit 3aed256 into sparckles:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants