ci: build artifacts on every push and pull

[sansyrox]

Description

Changing this as I want to build an artifact on every PR. That way it will be easier for us to just download the artifact and test it on our PC.

[netlify]

✅ Deploy Preview for robyn canceled.

Name	Link
🔨 Latest commit	6076bde
🔍 Latest deploy log	https://app.netlify.com/sites/robyn/deploys/63dc212f242a4b000952548a

[sansyrox]

Hey @AntoineRR 👋

The rationale behind this is that the top-level tag checking doesn't allow the jobs to run on every PR, and hence we won't be generating build artifacts when required.

[AntoineRR]

Yes that was the goal of my previous PR actually, but I had no idea you used the artifacts from PR sorry. I found it overkill to build the package for every OS, and every Python version on each PR. I think there are way too many jobs running in PRs (more than 120 in this PR currently!).

Maybe we could only build one package for windows, linux and macos on PRs (based on Python 3.11 for example)? This way we would still have artifacts to test, but only 3 instead of I think 45 currently.

To achieve this, I would create a new workflow (called preview build maybe) that runs on PRs and keep the release workflow as it is.

What do you think @sansyrox ? Let me know if I misunderstood your needs around build artifacts.

[sansyrox]

Maybe we could only build one package for windows, linux and macos on PRs (based on Python 3.11 for example)? This way we would still have artifacts to test, but only 3 instead of I think 45 currently.

This is a great suggestion. Let's build the packages for the latest versions only

[AntoineRR]

Thanks! Let me know if you need help for this 😄

[sansyrox]

@AntoineRR , can you have another review whenever you get the time?

[AntoineRR]

@sansyrox I left you some comments 🙂
Two more things here:

• I think we could merge the last two jobs, linux and linux-cross together, it should be possible I think
• Is there an issue with the commit history? I think you merged your changes with one of my previous commit based on the commit message. Maybe you should reopen a new PR if it is too hard to fix?

[sansyrox]

Thanks for the suggestions 😄

I think we could merge the last two jobs, linux and linux-cross together, it should be possible I think

These two environments require different logic. It will make the pipeline unnecessarily complex in my opinion.

Is there an issue with the commit history? I think you merged your changes with one of my previous commit based on the commit message. Maybe you should reopen a new PR if it is too hard to fix?

All fixed :D

[AntoineRR]

There are some minor adjustments needed, but this looks great otherwise, good job! 😉

[AntoineRR]

Good job @sansyrox, LGTM! 👍