Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pre-commit hooks to use Ruff #364

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Conversation

patrick91
Copy link
Contributor

Description

Ruff is a much faster linter (written in rust), it also supports
sorting imports (replacing isort) and fixing issues.

@netlify
Copy link

netlify bot commented Jan 17, 2023

Deploy Preview for robyn canceled.

Name Link
🔨 Latest commit a81390e
🔍 Latest deploy log https://app.netlify.com/sites/robyn/deploys/63c71f0017570200095926aa

@@ -5,14 +5,10 @@ repos:
hooks:
- id: black
args: [--line-length=160]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 160 really what we want? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, btw, the default_stages at the top might not be what we'd like, @sansyrox was there a particular reason it is only set to push?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrick91

is 160 really what we want? :)

This was just something random. I just feel that 70 characters is a bit too less :p

ah, btw, the default_stages at the top might not be what we'd like, @sansyrox was there a particular reason it is only set to push?

@patrick91 , I am sorry but I don't understand what you mean by this. Can you please explain a bit more? 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, btw, the default_stages at the top might not be what we'd like, @sansyrox was there a particular reason it is only set to push?

Now, I understand. It was mistake 🤣

@patrick91 patrick91 marked this pull request as ready for review January 17, 2023 22:21
@sansyrox
Copy link
Member

Thank you @patrick91 😄 . I have a few questions on the PR.

@sansyrox sansyrox merged commit 3827350 into sparckles:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants