fix: better handling of route return type #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for robyn canceled.
|
|
@AntoineRR , thank you for your PR. Can we still return a dictionary in this PR? |
|
Yes sure! |
AntoineRR
force-pushed
the
response-fix
branch
from
f07b943 to
c831018
Compare
sansyrox
approved these changes
Jan 7, 2023
|
Hey @sansyrox, thanks for your review. I added docs regarding the types returned from a route in the |
sansyrox
reviewed
Jan 8, 2023
Comment on lines
+102
to
+117
| return { | ||
| "status_code": 200, | ||
| "body": "This is a regular response", | ||
| "type": "text", | ||
| "headers": {"Header": "header_value"}, | ||
| } |
There was a problem hiding this comment.
Hey @AntoineRR ,
The return type of json should be
return {
"status_code": 200,
"body": jsonify({"hello": "world"},
"headers": {"Content-Type": "application/json"},
}or just
return jsonify({"hello": "world"})It will be returning a Plain Text otherwise
There was a problem hiding this comment.
Oh my bad you're right, I will change this :)
There was a problem hiding this comment.
@sansyrox it should be ok now 🙂
AntoineRR
force-pushed
the
response-fix
branch
from
8f37c5c to
7485364
Compare
kliwongan
added a commit
to kliwongan/robyn
that referenced
this pull request
Jan 13, 2023
fix: better handling of route return type (sparckles#349)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I figured there are issues when you try to return something other than a string or a dict in a route. With this PR, you can return anything and most notably directly a
Response.We may want to add it to the doc if it seems relevant to you @sansyrox ?