feat: allow non string types in response #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for robyn canceled.
|
sansyrox
commented
Dec 17, 2022
|
|
||
| // convert the output to a PyDict | ||
| let res = Python::with_gil(|py| -> Result<Response> { | ||
| let output: Py<PyDict> = output.extract(py)?; |
There was a problem hiding this comment.
converting it to a response shouldn't be crazy hard tbh. I will try again tomorrow 😅
There was a problem hiding this comment.
I tried implementing it since FromPyObject conflicts with the Clone trait. The implementation becomes very hairy.
sansyrox
commented
Dec 17, 2022
sansyrox
commented
Dec 17, 2022
sansyrox
force-pushed
the
feat/non-string-response
branch
from
ba74a35 to
8120f24
Compare
sansyrox
force-pushed
the
feat/non-string-response
branch
from
1be8d8f to
79d83de
Compare
|
Clippy tests are passing now 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #