Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Railway deployment process. #316

Merged
merged 6 commits into from
Nov 21, 2022
Merged

Add Railway deployment process. #316

merged 6 commits into from
Nov 21, 2022

Conversation

carlosm27
Copy link
Contributor

Description

This PR fixes #93

@netlify
Copy link

netlify bot commented Nov 19, 2022

Deploy Preview for robyn canceled.

Name Link
🔨 Latest commit 39ce5f2
🔍 Latest deploy log https://app.netlify.com/sites/robyn/deploys/637bf8ae42b6d000081dda56

@carlosm27
Copy link
Contributor Author

I really appreciate any feedback. I have to write the code in main.py instead app.py. Every time I deployed with app.py the building process on Railway failed. But that is a thing with Railway, you have to have a main.py to start any app. Should I mention that issue explicitly?

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @carlosm27 . Thank you for the detailed documentation 😄 , and apologies for the late review.

I have some suggestions. Can you please have a look?

docs/hosting.md Outdated Show resolved Hide resolved
docs/hosting.md Show resolved Hide resolved
docs/hosting.md Outdated Show resolved Hide resolved
docs/hosting.md Outdated Show resolved Hide resolved
docs/hosting.md Show resolved Hide resolved
docs/hosting.md Outdated Show resolved Hide resolved
docs/hosting.md Outdated Show resolved Hide resolved
docs/hosting.md Outdated Show resolved Hide resolved
docs/hosting.md Outdated Show resolved Hide resolved
docs/hosting.md Outdated Show resolved Hide resolved
@carlosm27
Copy link
Contributor Author

No problem. Thank you for the suggestions. Let me know if I can add anything else.

@sansyrox
Copy link
Member

Thank you for the quick revert. 😄

I have to write the code in main.py instead app.py. Every time I deployed with app.py the building process on Railway failed. But that is a thing with Railway, you have to have a main.py to start any app.

Can you please mention this in the docs too?

@carlosm27
Copy link
Contributor Author

I changed it a little bit.

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one suggestion didn't go through.

@carlosm27
Copy link
Contributor Author

Which one?

@carlosm27
Copy link
Contributor Author

We have to write the code in main.py instead app.py. If there is no main.py file the building process will fail. But that is a thing with Railway, you have to have a main.py to start any app.

I think I added the text above in the wrong place. I think it makes more sense if I add it after the main.py. What do you think?

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work ✨ 🚀

@sansyrox sansyrox merged commit 697cfc1 into sparckles:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation about deployment
2 participants