SocketHeld::new refactor

[Jamyw7g]

Description

Reduce SocketHeld::new verbose code. And make it support both ipv4 and ipv6.

[netlify]

✅ Deploy Preview for robyn canceled.

Name	Link
🔨 Latest commit	3cd94b0
🔍 Latest deploy log	https://app.netlify.com/sites/robyn/deploys/63529ccf2b0839000b66d348

[sansyrox]

Oh wow!

[sansyrox]

@Jamyw7g , I didn't realise this was still in draft.

[Jamyw7g]

@sansyrox I want to make it support both ipv4 and ipv6. I will submit a new commit.

[sansyrox]

Okay @Jamyw7g , lmk whenever it is up for review.

[Jamyw7g]

That's all.

[sansyrox]

Looks good. Just need to verify it on a windows machine.

Great work! ❇️

[sansyrox]

@guilefoylegaurav , I am unable to add you as a reviewer idk why. Can you please have a look? Thank you again 😄

[guilefoylegaurav]

@guilefoylegaurav , I am unable to add you as a reviewer idk why. Can you please have a look? Thank you again 😄

Np, @sansyrox - I have examined the PR. I have merged this PR branch into one reflecting main, in my local Windows machine and ran tests.

• 25/26 tests passed (Windows 10)
• Our familiar test_global_index_request() has been failing on Windows since the last few PRs customarily, even before this PR was merged
• The rest of the tests ran successfully

LGTM!

test_base_url.py ..F.                                                                                            [ 15%]
test_delete_requests.py ..                                                                                       [ 23%]
test_env_populator.py .                                                                                          [ 26%]
test_get_requests.py ......                                                                                      [ 50%]
test_patch_requests.py ..                                                                                        [ 57%]
test_post_requests.py ....                                                                                       [ 73%]
test_put_requests.py ..                                                                                          [ 80%]
test_status_code.py ....                                                                                         [ 96%]
test_web_sockets.py .                                                                                            [100%]

====================================================== FAILURES =======================================================
______________________________________________ test_global_index_request ______________________________________________

[sansyrox]

Thanks @guilefoylegaurav 😄