Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and publish wheels on GitHub Actions #26

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Build and publish wheels on GitHub Actions #26

merged 2 commits into from
Jun 25, 2021

Conversation

messense
Copy link
Contributor

You need to setup the PYPI_PASSWORD secret, use a api token is recommended.

messense added 2 commits June 24, 2021 16:30
@messense
Build and publish wheels on GitHub Actions
79a5fc1
@messense
Remove Python 3.6
8ec2345 
It has weird errors when importing

```
thread '<unnamed>' panicked at 'assertion failed: `(left != right)`
  left: `0`,
 right: `0`', C:\Users\runneradmin\.cargo\git\checkouts\pyo3-a22e69bc62b9f0fd\13cd092\src\gil.rs:83:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\robyn\__init__.py", line 1, in <module>
    from .robyn import Server
pyo3_runtime.PanicException: assertion failed: `(left != right)`
  left: `0`,
 right: `0`
```
@messense
Copy link
Contributor Author

Example run: https://github.com/messense/robyn/actions/runs/967265751

sansyrox
sansyrox approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@sansyrox sansyrox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@messense , this looks amazing! 😄

I will create a stable branch off my main. Can you add a condition such that it only triggers when pushed on stable?

@messense
Copy link
Contributor Author

I will create a stable branch off my main. Can you add a condition such that it only triggers when pushed on stable?

Sure.
But I don't think it's really needed, currently it builds the wheels on push and PR, only publishes them to PyPI on new git tag push.

@messense
Copy link
Contributor Author

messense commented Jun 25, 2021 •
edited
Loading

@davidhewitt There is a weird GIL related error on Python 3.6, I'm not sure why, it works on Python 3.7 and later.
See https://github.com/messense/robyn/runs/2902786370?check_suite_focus=true

Maybe related to the use of prepare_freethreaded_python? https://github.com/sansyrox/robyn/blob/35e99f038a88101f0a2d697eb2aa1bbc18a6cb96/src/lib.rs#L29

@sansyrox
Copy link
Member

But I don't think it's really needed, currently it builds the wheels on push and PR, only publishes them to PyPI on new git tag push.
@messense , it makes sense then. Thank you for the amazing contribution. I will be merging this PR! 🚀

@sansyrox sansyrox merged commit 389d2b7 into sparckles:main Jun 25, 2021
@messense messense deleted the ci branch June 25, 2021 12:31
@sansyrox
Copy link
Member

sansyrox commented Jun 26, 2021 •
edited
Loading

Hey @messense ,
Thank you for the amazing work. We just released the latest version at : https://pypi.org/project/robyn/0.4.1/

You can also join our gitter community if you are interested.

@davidhewitt
Copy link

Maybe related to the use of prepare_freethreaded_python?

Possibly. There was a lot of changes to python initialization in Python 3.7.

We also changed the code a lot for PyO3 0.14, so if it works for "future" versions then I'm not too worried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sansyrox sansyrox sansyrox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@messense @sansyrox @davidhewitt