Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): move pytest from CircleCi to Github Actions #241

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

AntoineRR
Copy link
Collaborator

Description

  • Delete the circle CI config
  • Run pytest using Github Actions (the only job that was still running on Circle CI)
  • Fix the issue with the --no-sdist flag for maturin build (versions of maturin were different in the test-requirements.txt and in the dev-requirements.txt)

This PR fixes #240

@netlify
Copy link

netlify bot commented Jul 19, 2022

Deploy Preview for robyn canceled.

Name Link
🔨 Latest commit 084b0f8
🔍 Latest deploy log https://app.netlify.com/sites/robyn/deploys/62d6f3345a3860000893ddfd

@@ -1,5 +1,5 @@
pytest==6.2.5
maturin
maturin==0.12.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ;)

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Thank you! :D

@sansyrox sansyrox merged commit 38a86b3 into sparckles:main Jul 20, 2022
@sansyrox
Copy link
Member

Also @AntoineRR , this challenge was eligible for the europython challenge. Can you dm me your location, shirt size and mobile number on twitter or gitter for me to arrange the delivery?

@AntoineRR
Copy link
Collaborator Author

Ooh that's really cool thank you! I don't have twitter and gitter, but figured I have your Linkedin, I dmed you there ;) Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Move away from circle ci
2 participants