Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Actions and add Python 3.10 #230

Merged
merged 15 commits into from
Jul 16, 2022
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 10, 2022

No description provided.

@netlify
Copy link

netlify bot commented Jul 10, 2022

Deploy Preview for robyn canceled.

Name Link
🔨 Latest commit ab2e43a
🔍 Latest deploy log https://app.netlify.com/sites/robyn/deploys/62cecca53883a10008777e99

@sansyrox
Copy link
Member

@cclauss , what is the error that you were getting?

@cclauss
Copy link
Contributor Author

cclauss commented Jul 12, 2022

@sansyrox
Copy link
Member

@cclauss , I am unable to understand what it means by this statement

/home/runner/work/_actions/uraimo/run-on-arch-action/v2.2.0/src/run-on-arch-commands.sh: line 5: python3.10: command not found

Does it mean that we are using the wrong image? Or the image doesn't exist? Or is it not possible to run 3.10 on linux cross? Or something else?

@cclauss
Copy link
Contributor Author

cclauss commented Jul 13, 2022

The build container step succeeds but the run container step fails. This means that there is no Python 3.10 executable inside the container. My recommendation is that we land this PR as is because it is a nice improvement. After this has landed, we can circle back with another PR that ensures that Py310 is in the container.

@cclauss
Copy link
Contributor Author

cclauss commented Jul 13, 2022

When you land this, please do Squash and merge so we don't add a dozen-plus new commits.
Screenshot 2022-07-13 at 14 34 02

If you cannot do that, let me know and I will squash on my side.

@sansyrox
Copy link
Member

@cclauss , thank you! :D This looks good at first glance. I am at a conference currently, I will have a proper look by Thursday eod.

@cclauss
Copy link
Contributor Author

cclauss commented Jul 13, 2022

Thanks. No rush.

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@sansyrox sansyrox merged commit 12bfde9 into sparckles:main Jul 16, 2022
@cclauss cclauss deleted the patch-3 branch July 17, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants