Add Event handlers #154
Merged
Add Event handlers #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for robyn canceled. 🔨 Explore the source changes: cfe74e0 🔍 Inspect the deploy log: https://app.netlify.com/sites/robyn/deploys/61e5e5c5ba9b220008e40d8f |
sansyrox
force-pushed
the
event_handlers
branch
from
93790ca to
5f97e89
Compare
|
@klaa97 , this PR adds events in Robyn. Could you please have a look at this PR once? |
klaa97
approved these changes
Jan 16, 2022
robyn/__init__.py
Outdated
| return | ||
|
|
||
| is_async = asyncio.iscoroutinefunction(handler) | ||
| if event_type.lower() == "startup": |
There was a problem hiding this comment.
Very minor, but for clarity, I would consider to:
- Extract the "startup"/"shutdown" string either in an Enum (like Class(str, Enum) or as constants
- DIrectly use "startup"/"shutdown" as keys for the dictionary
event_handlers
sansyrox
force-pushed
the
event_handlers
branch
from
1dd54cf to
cfe74e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #153
TODO: