-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't access new or updated route while on dev option #439
Comments
Just wondering, at the app = Robyn(File) |
Nevermind, I tested it myself and it's happening. Not sure if this is new, I remember that it was working, That or my memory is going to get nervous 😰 |
@ibnbay99 , thank you for opening the issue. This is really strange. I will have a look |
@Noborita9 , I'm forgot to block my code with code block.... updated my first comment |
@sansyrox I was able to reproduce the bug, and I think it is linked with how we handle hot reloading currently. We do not populate the router and middleware router again but still use their old values. |
@AntoineRR , thank you! That sounds good to me 😊😊 |
Ok I'll take this subject then 😉 |
@AntoineRR , I was thinking we should introduce some smoke testing for issues like this. I will be happy to write some to help with the PR. What say? |
Sound good to me! I'm not sure how to write such tests for now so your help is welcome 😊 |
Bug Description
Dev option for hot reloading is not working to recompile python code into rust object
Steps to Reproduce
python app.py --dev
Update return value of hello function, or add new route
DEBUG:fsevents:NativeEvent(path="/pp.py", inode=30320742, flags=11400, id=285275140): is_file, is_inode_meta_mod, is_modified
DEBUG:fsevents:NativeEvent(path="web_api/app.py~", inode=30678452, flags=15700, id=285275143): is_coalesced, is_created, is_file, is_inode_meta_mod, is_modified, is_owner_change, is_removed
DEBUG:fsevents:queue_event <FileModifiedEvent: event_type=modified, src_path='web_api/app.py', is_directory=False>
DEBUG:fsevents:queue_event <FileCreatedEvent: event_type=created, src_path='web_api/app.py~', is_directory=False>
DEBUG:fsevents:queue_event <DirModifiedEvent: event_type=modified, src_path='web_api', is_directory=True>
DEBUG:fsevents:queue_event <FileModifiedEvent: event_type=modified, src_path='web_api/app.py~', is_directory=False>
DEBUG:fsevents:queue_event <FileDeletedEvent: event_type=deleted, src_path='web_api/app.py~', is_directory=False>
DEBUG:fsevents:queue_event <DirModifiedEvent: event_type=modified, src_path='web_api', is_directory=True>
But when rehit GET root path, still return old value or new route is not available
Your operating system
on macbook intel, mac os monterey
Your Python version (
python --version
)3.10.9
Your Robyn version
0.25.0
Additional Info
No response
The text was updated successfully, but these errors were encountered: