New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Return 404 status code when route isn't set #376

Closed

AntoineRR opened this issue Jan 27, 2023 · 1 comment · Fixed by #380

Collaborator

AntoineRR commented Jan 27, 2023

Description

Currently requesting a unknown route will result in getting an empty response with a 200 status code.

Expected Behavior

We should probably return a 404 status code automatically when this happens.

Member

sansyrox commented Jan 29, 2023

This should not happen. I am surprised that we don't have a test for this.

AntoineRR mentioned this issue

fix: return 404 status code when route isn't found #380

Merged

sansyrox closed this as completed in #380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment