Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Allow global level Response headers #335

Closed
sansyrox opened this issue Dec 13, 2022 · 1 comment · Fixed by #410
Closed

[Feature Request] Allow global level Response headers #335

sansyrox opened this issue Dec 13, 2022 · 1 comment · Fixed by #410
Labels
enhancement New feature or request

Comments

@sansyrox
Copy link
Member

sansyrox commented Dec 13, 2022 •
edited
Loading

Current Behavior

Ideally, I would want to add it in this PR: #331 but I think it is already long enough.
Desired Behavior

We have the ability to add global request headers in Robyn(see here: https://github.com/sansyrox/robyn/blob/c7443963859a39b1998e032bcb9e682fbe563dbc/src/server.rs#L229 )

Similarly, we would love to allow global level Response headers.

Screenshots / Mockups

Alternatives
@sansyrox
Copy link
Member Author

sansyrox commented Jan 6, 2023

@ParthS007 , would you like to have a look at this issue?

@ParthS007 ParthS007 mentioned this issue Feb 12, 2023
Merged
@AntoineRR AntoineRR added the enhancement New feature or request label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow global level Response headers ParthS007/robyn
2 participants
@sansyrox @AntoineRR