Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure #166

Closed
thewchan opened this issue Mar 3, 2022 · 19 comments
Closed

Build failure #166

thewchan opened this issue Mar 3, 2022 · 19 comments

Comments

@thewchan
Copy link

thewchan commented Mar 3, 2022

Hi, getting another build error for 0.14.0; it's something with the rust compilation again: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=467486&view=logs&j=4f922444-fdfe-5dcf-b824-02f86439ef14&t=b2a8456a-fb11-5506-ca32-5ccd32538dc0

  error[E0277]: the trait bound `MyWs: actix::actor::Actor` is not satisfied
     --> src/web_socket_connection.rs:62:37
      |
  62  |     fn started(&mut self, ctx: &mut WebsocketContext<Self>) {
      |                                     ^^^^^^^^^^^^^^^^^^^^^^ the trait `actix::actor::Actor` is not implemented for `MyWs`
      |
  note: required by a bound in `WebsocketContext`
     --> /home/conda/feedstock_root/build_artifacts/robyn_1646278130206/_build_env/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/actix-web-actors-4.1.0/src/ws.rs:373:8
      |
  373 |     A: Actor<Context = WebsocketContext<A>>,
      |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `WebsocketContext`

There are five other errors that are similar/identical.

@sansyrox
Copy link
Member

sansyrox commented Mar 3, 2022

Oh, wow. This is not good. I suspect this has something to do with a new rust stable being released yesterday and robyn relying on a beta version of actix.

No worries, I will take a look this.

@sansyrox
Copy link
Member

sansyrox commented Mar 3, 2022

Also, @thewchan i really appreciate you reporting issues here :D

@thewchan
Copy link
Author

Newest version still incur the following errors:

  error[E0277]: the trait bound `MyWs: actix::actor::Actor` is not satisfied
     --> src/web_socket_connection.rs:28:15
      |
  28  |     ctx: &mut ws::WebsocketContext<MyWs>,
      |               ^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `actix::actor::Actor` is not implemented for `MyWs`
      |
  note: required by a bound in `WebsocketContext`
     --> /home/conda/feedstock_root/build_artifacts/robyn_1648178634645/_build_env/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/actix-web-actors-4.1.0/src/ws.rs:373:8
      |
  373 |     A: Actor<Context = WebsocketContext<A>>,
      |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `WebsocketContext`


  error[E0277]: the trait bound `MyWs: actix::actor::Actor` is not satisfied
     --> src/web_socket_connection.rs:75:20
      |
  75  |     type Context = ws::WebsocketContext<Self>;
      |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `actix::actor::Actor` is not implemented for `MyWs`
      |
  note: required by a bound in `WebsocketContext`
     --> /home/conda/feedstock_root/build_artifacts/robyn_1648178634645/_build_env/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/actix-web-actors-4.1.0/src/ws.rs:373:8
      |
  For more information about this error, try `rustc --explain E0277`.

  Error: command ['maturin', 'pep517', 'build-wheel', '-i', '/home/conda/feedstock_root/build_artifacts/robyn_1648178634645/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/bin/python', '--compatibility', 'off'] returned non-zero exit status 1
  error: subprocess-exited-with-error

@sansyrox
Copy link
Member

@thewchan , this is interesting. As everything passed on both my local builds and cloud builds. I think this is somewhat related to the latest rust version. I will test it out.

Also, is there someway that I can have the same version to your builds everytime?

@sansyrox sansyrox mentioned this issue Mar 26, 2022
@sansyrox
Copy link
Member

sansyrox commented Apr 9, 2022

@thewchan , I was able to finally figure out why this is happening. So, the build crashes every time the latest rust stable version is released(in every 6 weeks) as I am using a beta library for faster speeds.

Now, I am unable to see the logs(probably since they have expired) but ig I would need to be compiling it with the latest rust version or find some other alternative.

So, the build will be fixed in the next version released.

Thanks again. :D

@thewchan
Copy link
Author

Thanks! I'll will keep an eye out and keep you posted.

@sansyrox
Copy link
Member

Hi @thewchan , can you check if the build faillure has been fixed in the latest update?

@thewchan
Copy link
Author

@sansyrox still not working out it seems. Can you access these build logs?
https://github.com/conda-forge/robyn-feedstock/pull/17/checks?check_run_id=6232337032

@sansyrox
Copy link
Member

sansyrox commented May 1, 2022

@thewchan , https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=499695&view=logs&j=4f922444-fdfe-5dcf-b824-02f86439ef14&t=b2a8456a-fb11-5506-ca32-5ccd32538dc0

I just read through this log. Is the docker image available on docker hub? Or can you point me to the config that is being used here?

I would like to replicate the issue but I am unable to do so.

Everything is building fine on my machine. I can try building the same thing on my linux box, but given that it is building on the pipelines, it should not be of much difference.

@thewchan
Copy link
Author

thewchan commented May 4, 2022

Do you mean the docker image for the rust distribution?

@sansyrox
Copy link
Member

sansyrox commented May 4, 2022

Do you mean the docker image for the rust distribution?

Yess

@thewchan
Copy link
Author

thewchan commented May 4, 2022

I will inquire and get back to you, thanks!

@sansyrox
Copy link
Member

sansyrox commented May 4, 2022

Thank you so much 😃

@thewchan
Copy link
Author

thewchan commented May 9, 2022

https://github.com/conda-forge/docker-images

^^^ It seems that we don't pull a specific rust container but rather whatever is default in these linux containers?

@thewchan
Copy link
Author

thewchan commented May 9, 2022

Here's what the admins said:

image

@sansyrox
Copy link
Member

sansyrox commented May 9, 2022

Thank you so much @thewchan . I was able to replicate and fix the issues. Everything should be hopefully fixed in 0.16.2. Can you check once?

@thewchan
Copy link
Author

thewchan commented May 9, 2022

Awesome, I'm waiting downstream for it to detect 0.16.2, will keep you posted

@thewchan
Copy link
Author

Success!
image

@sansyrox
Copy link
Member

Yess!! Thanks @thewchan for all the help. Feel free to close the issue once you've merged the PR upstream :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants