Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python linter setup #129

Closed
Kludex opened this issue Dec 11, 2021 · 3 comments · Fixed by #143
Closed

Add Python linter setup #129

Kludex opened this issue Dec 11, 2021 · 3 comments · Fixed by #143

Comments

@Kludex
Copy link
Contributor

Kludex commented Dec 11, 2021

What do you think about adding some tooling here? e.g. black, isort and flake8

@sansyrox
Copy link
Member

I usually use format on save and use black as my linter.

Adding a project-wide linter is definitely a good idea. Do you have some suggestions/strong feelings for the others?

@Kludex
Copy link
Contributor Author

Kludex commented Dec 11, 2021

Do you have some suggestions/strong feelings for the others?

You mean isort and flake8? Most of the projects that I'm aware add at least those 🤔

I usually use format on save and use black as my linter.

Are you sure? 🤔 Because I do that as well, and it was automatically formatting some files there.

@sansyrox
Copy link
Member

sansyrox commented Dec 11, 2021

Are you sure? 🤔 Because I do that as well, and it was automatically formatting some files there.

Probably my editor was misconfigured then. But a project-wide linter is a good approach.

What are the pro(s)/con(s) of using more than one linter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants