New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robyn's speed can be improved imo #155

Open

sansyrox opened this issue Jan 23, 2022 · 3 comments

Member

sansyrox commented Jan 23, 2022

https://docs.rs/http_router/0.1.0/http_router/index.html

This package populates the macros, which are also thread-safe. So, releasing and acquiring RwLock should not be a bottleneck anymore.

Can try this.

Member Author

sansyrox commented Jan 23, 2022

Cloning an Arc makes little sense if we want to use a RwLock. Can try to get rid of it.

https://stackoverflow.com/questions/33116317/when-would-you-use-a-mutex-without-an-arc

Member Author

sansyrox commented Jan 25, 2022

Partial fix at : #156

Member Author

sansyrox commented Jun 9, 2022

https://github.com/squeaky-pl/japronto/blob/master/src/japronto/router/analyzer.py#L43

Have a look at this implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment