Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove get_fileext() method #16

Closed
jdavies-st opened this issue Oct 26, 2020 · 3 comments · Fixed by #400
Closed

Remove get_fileext() method #16

jdavies-st opened this issue Oct 26, 2020 · 3 comments · Fixed by #400
Assignees
@emolter
Milestone
0.4.0

Comments

@jdavies-st
Copy link
Contributor

It's not clear what it does or why it exists. Or why it is public.

stdatamodels/src/stdatamodels/model_base.py

Lines 974 to 975 in 8f9c64b

def get_fileext(self):
return 'fits'

@jdavies-st
Copy link
Contributor Author

Currently it gets called by jwst.stpipe.subproc:

https://github.com/spacetelescope/jwst/blob/caa542604b6907e4df12b061f677899ce90022ab/jwst/stpipe/subproc.py#L62-L65

@jdavies-st jdavies-st added this to the 0.4.0 milestone Sep 2, 2021
@braingram
Copy link
Collaborator

This now appears to be entirely unused:
https://github.com/search?q=repo%3Aspacetelescope%2Fstpipe%20get_fileext&type=code
https://github.com/search?q=repo%3Aspacetelescope%2Fjwst%20get_fileext&type=code

@braingram braingram mentioned this issue Nov 15, 2024
Merged
5 tasks
@emolter emolter self-assigned this Feb 11, 2025
@emolter
Copy link
Contributor

emolter commented Feb 11, 2025

This removal is ready to be enforced

@stscijgbot-jp stscijgbot-jp mentioned this issue Feb 12, 2025
Closed
@emolter emolter mentioned this issue Feb 12, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emolter emolter

Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Remove deprecated get_fileext() method emolter/stdatamodels
3 participants
@braingram @jdavies-st @emolter