Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous updates following RTB review #99

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

schlafly
Copy link
Collaborator

@schlafly schlafly commented Feb 13, 2024

  • Rename seed -> rng_seed in documentation.
  • Extend documentation of "faintmag" in source generation.
  • Input catalog PAs should be in degrees, not radians.
  • Use dark_slope rather than dark image for simulation dark current.
  • Revamp reference file & default parameter gathering.
  • Issue a warning if --usecrds is not set.
  • Support truncated exposures

@schlafly schlafly requested a review from a team as a code owner February 13, 2024 13:16
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (a3f71b7) 92.59% compared to head (510c55b) 92.43%.

Files Patch % Lines
romanisim/image.py 50.76% 32 Missing ⚠️
romanisim/l1.py 62.50% 3 Missing ⚠️
romanisim/ris_make_utils.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   92.59%   92.43%   -0.16%     
==========================================
  Files          16       16              
  Lines        1471     1494      +23     
==========================================
+ Hits         1362     1381      +19     
- Misses        109      113       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly schlafly merged commit 3083726 into spacetelescope:main Feb 13, 2024
20 of 22 checks passed
@schlafly schlafly deleted the rtb-updates branch February 13, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant