-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for webbpsf 1.2.1. #71
Conversation
@zacharyburnett , would you mind taking a look at this? webbpsf 1.2.1 came out and needed a corresponding bump to the data file that the CI downloads. I tried to make that change there but somehow the CI is still seeing 1.1.1 (error message from CI: OSError: WebbPSF data package has version 1.1.1, but 1.2.1 is needed). I can look at the CI logs and see that it is downloading the new files in the CI for this PR, and when I download those files myself they work fine with webbpsf 1.2.1. Do I need to do something special to "clear the cache" or something to get it to see the right files, or have I screwed something else up? Thanks! |
After clearing the cache I got this to work better. I suspect the hashing going on in the CI is not working quite right and it should have been recognizing that the new files were different but it wasn't actually doing that. There is still some additional issue where the tox codecov runs are failing, but I don't understand that. @zacharyburnett , sorry, I can't make heads or tails of this one. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
=======================================
Coverage 90.37% 90.37%
=======================================
Files 16 16
Lines 1444 1444
=======================================
Hits 1305 1305
Misses 139 139 ☔ View full report in Codecov by Sentry. |
Okay, this is now solved. At least four relevant issues:
I think that's everything! But I don't really know what I'm doing with any of these. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I defer to @zacharyburnett on the CI issues.
This updates the webbpsf data files used in CI to the latest versions.