Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve content of romanisim output files #60

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

schlafly
Copy link
Collaborator

  • Move romanisim dq & persistence structures outside of the 'roman' asdf keyword, since romancal assumes it will understand everything under that keyword.
  • Add the WCS to romanisim L2 output.
  • Remove custom logging formatting to avoid stpipe interaction issue.
  • Move crds module imports out of module level.

schlafly added 2 commits June 16, 2023 15:22
…n' asdf extension, since the pipeline expects to know about everything in that block.
…teraction issue.

* Generate catalogs with the standard bandpass nomenclature by default.
* Move crds module imports out of module level.
* Include WCS in L2 output files.
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage: 93.10% and project coverage change: -0.13 ⚠️

Comparison is base (efa3483) 90.00% compared to head (ec3403e) 89.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   90.00%   89.87%   -0.13%     
==========================================
  Files          15       15              
  Lines        1351     1393      +42     
==========================================
+ Hits         1216     1252      +36     
- Misses        135      141       +6     
Impacted Files Coverage Δ
romanisim/__init__.py 75.00% <ø> (-2.78%) ⬇️
romanisim/bandpass.py 100.00% <ø> (ø)
romanisim/image.py 85.53% <78.57%> (-1.32%) ⬇️
romanisim/wcs.py 91.78% <96.96%> (+1.42%) ⬆️
romanisim/catalog.py 97.74% <100.00%> (+0.05%) ⬆️
romanisim/l1.py 90.74% <100.00%> (+0.05%) ⬆️
romanisim/persistence.py 98.70% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@schlafly schlafly marked this pull request as ready for review June 23, 2023 18:27
@schlafly schlafly requested a review from a team as a code owner June 23, 2023 18:27
@schlafly schlafly merged commit 2ad8531 into spacetelescope:main Jun 23, 2023
@schlafly schlafly deleted the move-dq branch June 23, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant