Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document feature for generating images with all SCAs #129

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

bmorris3
Copy link
Contributor

@bmorris3 bmorris3 commented Jun 25, 2024

On main, users can generate images for all SCAs using romanisim-make-image ... --sca -1 ..., in a case that gets caught here:

if args.sca == -1:
# simulate all 18 SCAs sequentially
origfilename = copy(args.filename)
origprevious = copy(args.previous)
for i in range(1, 19):
args.sca = i
args.filename = origfilename.format(f'WFI{args.sca:02d}')
if origprevious is not None:
args.previous = origprevious.format(f'WFI{args.sca:02d}')
go(args)
return

This feature isn't written about in the docs or in the argument's help notes, so I've added a note to both.

@bmorris3 bmorris3 requested a review from a team as a code owner June 25, 2024 17:55
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.44%. Comparing base (0a1aac5) to head (1bf6bd7).
Report is 62 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   90.78%   87.44%   -3.34%     
==========================================
  Files          17       17              
  Lines        1671     1689      +18     
==========================================
- Hits         1517     1477      -40     
- Misses        154      212      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly
Copy link
Collaborator

Thank you!

@schlafly schlafly merged commit 1c56a53 into spacetelescope:main Jun 25, 2024
13 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants