-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCSB-155] build with Numpy 2.0 #127
[SCSB-155] build with Numpy 2.0 #127
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 90.78% 90.94% +0.16%
==========================================
Files 17 17
Lines 1671 1701 +30
==========================================
+ Hits 1517 1547 +30
Misses 154 154 ☔ View full report in Codecov by Sentry. |
numpy>=2.0.0rc2
in build-system.requires
converting this back to draft to address WebbPSF data issues in the CI |
Oh, thanks for the reminder, I fixed the WebbPSF files here: |
This was left as a draft, so I ignored it; should we move forward with this? |
c277669
to
73a7113
Compare
Sorry, just because I'm dumb; this isn't setting the dependency to require numpy > 2, but is instead setting something in the build system, which has little meaning to me. What are we trying to accomplish here? |
Ugh, never mind, you explained it well in the PR, merging, sorry. |
resolves SCSB-155
Numpy 2.0 is scheduled for release on June 19th. Due to the C ABI updates, Python projects that build C extensions are required to build against Numpy 2.0 in order to use Numpy 2.0 in runtime.
This is backwards-compatible with Numpy versions in runtime as far back as
1.26
this PR pins
numpy>=2.0.0rc2
inbuild-system.requires
Note
this PR was generated automatically by
batchpr
🤖