Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCSB-155] build with Numpy 2.0 #127

Merged

Conversation

zacharyburnett
Copy link
Collaborator

resolves SCSB-155

Numpy 2.0 is scheduled for release on June 19th. Due to the C ABI updates, Python projects that build C extensions are required to build against Numpy 2.0 in order to use Numpy 2.0 in runtime.
This is backwards-compatible with Numpy versions in runtime as far back as 1.26

this PR pins numpy>=2.0.0rc2 in build-system.requires

Note

this PR was generated automatically by batchpr 🤖

@zacharyburnett zacharyburnett self-assigned this May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.94%. Comparing base (0a1aac5) to head (73a7113).
Report is 62 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   90.78%   90.94%   +0.16%     
==========================================
  Files          17       17              
  Lines        1671     1701      +30     
==========================================
+ Hits         1517     1547      +30     
  Misses        154      154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett changed the title pin numpy>=2.0.0rc2 in build-system.requires [SCSB-155] build with Numpy 2.0 release candidate May 31, 2024
@zacharyburnett zacharyburnett marked this pull request as ready for review June 4, 2024 14:23
@zacharyburnett zacharyburnett requested a review from a team as a code owner June 4, 2024 14:23
@zacharyburnett
Copy link
Collaborator Author

converting this back to draft to address WebbPSF data issues in the CI

@zacharyburnett zacharyburnett marked this pull request as draft June 4, 2024 14:24
@schlafly
Copy link
Collaborator

schlafly commented Jun 4, 2024

Oh, thanks for the reminder, I fixed the WebbPSF files here:
#126
I do have to clear the cache every time, so there is something weird about the hashing, but it only needs to be done a few times a year.

@schlafly
Copy link
Collaborator

schlafly commented Jul 3, 2024

This was left as a draft, so I ignored it; should we move forward with this?

pyproject.toml Outdated Show resolved Hide resolved
@zacharyburnett zacharyburnett changed the title [SCSB-155] build with Numpy 2.0 release candidate [SCSB-155] build with Numpy 2.0 Jul 3, 2024
@zacharyburnett zacharyburnett force-pushed the pin_numpy_build_requirement branch from c277669 to 73a7113 Compare July 3, 2024 17:58
@zacharyburnett zacharyburnett marked this pull request as ready for review July 3, 2024 17:58
@schlafly
Copy link
Collaborator

schlafly commented Jul 3, 2024

Sorry, just because I'm dumb; this isn't setting the dependency to require numpy > 2, but is instead setting something in the build system, which has little meaning to me. What are we trying to accomplish here?

@schlafly
Copy link
Collaborator

schlafly commented Jul 3, 2024

Ugh, never mind, you explained it well in the PR, merging, sorry.

@schlafly schlafly merged commit 2bf1f6b into spacetelescope:main Jul 3, 2024
22 checks passed
@zacharyburnett zacharyburnett deleted the pin_numpy_build_requirement branch July 3, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants