Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure extension modules are present in built wheel #121

Merged
merged 5 commits into from
May 14, 2024
Merged

ensure extension modules are present in built wheel #121

merged 5 commits into from
May 14, 2024

Conversation

zacharyburnett
Copy link
Collaborator

Resolves SCSB-149

@zacharyburnett zacharyburnett self-assigned this May 6, 2024
@zacharyburnett zacharyburnett requested a review from a team as a code owner May 6, 2024 16:32
@codecov Codecov
Copy link

codecov bot commented May 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.73%. Comparing base (725b7cb) to head (8aeccf2).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   92.44%   90.73%   -1.71%     
==========================================
  Files          16       16              
  Lines        1509     1630     +121     
==========================================
+ Hits         1395     1479      +84     
- Misses        114      151      +37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett marked this pull request as draft May 6, 2024 16:43
schlafly
schlafly approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; was this not working?

@zacharyburnett
Copy link
Collaborator Author

Looks good to me; was this not working?

there was an issue with the stsci.stimage that slipped through the cracks and was published onto pyPI; I just wanted to make sure that doesn't happen in other repos

@zacharyburnett
Copy link
Collaborator Author

the fftw3 issue is here too in the ARM64 build; https://github.com/spacetelescope/romanisim/actions/runs/8973449274/job/24643649477?pr=121#step:7:1002

@zacharyburnett zacharyburnett mentioned this pull request May 13, 2024
Closed
@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented May 13, 2024 •
edited
Loading

raised an issue about this: OpenAstronomy/github-actions-workflows#201

@zacharyburnett zacharyburnett marked this pull request as ready for review May 14, 2024 14:23
@zacharyburnett zacharyburnett merged commit 30b5adf into spacetelescope:main May 14, 2024
21 of 22 checks passed
@zacharyburnett zacharyburnett deleted the scsb149 branch May 14, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlafly schlafly schlafly approved these changes

Assignees

@zacharyburnett zacharyburnett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharyburnett @schlafly