Convert counts to integer to avoid floating point weirdness. #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clips the number of photons entering a pixel over an exposure to 2 * 10**9 to avoid floating point / integer math issues. This seems like a lot of photons, but a 0th mag star should generate O(10^11) photons per second per meter squared, so it's not that many. Roman saturates at O(10^5) photons and we really only need to care about handling enough to saturate in a single read; this lets us handle exposure times up to ~2*10^4 reads which seems like more than enough. The non-linearity correction will have issues long before this and would be the next thing to look at if we wanted to do a better job with very bright stars.