Truncate some too-long dummy metadata strings. #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulHuwe
approved these changes
Apr 18, 2024
|
Is it clear to you that you would want to do this in RDM? Ideally validate would do it, but I don't know if we have special RDM code in validate or if that just gets passed straight down to asdf, which doesn't know about these archive keywords? You could just update the default values in RDM which would be easier, I guess. |
|
RDM wraps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a handful of dummy strings in from the roman_datamodels maker utilities that are too long to be parsed by the archive. We truncate those here to be be shorter.
We could consider making the defaults for these strings fit within the archive schema lengths in roman_datamodels or having validation code check these string lengths. That would avoid this sort of issue.