Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use numerical inverse to improve WCS accuracy #110

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

schlafly
Copy link
Collaborator

There is an issue with the distortion reference files in CRDS such that wcs.world_to_pixel(wcs.pixel_to_world(...)) only inverts at the 0.05 pix level. That makes it impossible to do astrometry better than ~0.05 pix. This replaces wcs.world_to_pixel with wcs.numerical_inverse to avoid this issue. This is slightly slower, so we will restore the original approach when the reference file issue is resolved.

@schlafly schlafly requested a review from a team as a code owner April 17, 2024 18:41
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (725b7cb) to head (dedd5e1).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   92.44%   92.21%   -0.23%     
==========================================
  Files          16       16              
  Lines        1509     1593      +84     
==========================================
+ Hits         1395     1469      +74     
- Misses        114      124      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly schlafly merged commit 33a01a9 into spacetelescope:main Apr 18, 2024
19 of 20 checks passed
@schlafly schlafly deleted the use-wcs-numerical-inverse branch April 18, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant