Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SCA -1 to indicate that multiple images should be made. #109

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

schlafly
Copy link
Collaborator

This PR adds a few assorted romanisim features:

  • specifying SCA -1 to romanisim-make-image means looping over all 18 detectors
  • Use a seed for the flat field implementation rather than making a separate draw for the flat field, to enable deterministic output.
  • Improve the handling of WCS in output products.
  • Instantiate the PSFs a little further from the corners of the WFI detectors
  • Handle NaNs in positions and fluxes in catalogs by ignoring these sources.

@schlafly schlafly requested a review from a team as a code owner April 10, 2024 18:18
@schlafly schlafly requested a review from PaulHuwe April 10, 2024 18:18
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.21%. Comparing base (725b7cb) to head (790988c).
Report is 50 commits behind head on main.

Files Patch % Lines
romanisim/ris_make_utils.py 69.23% 4 Missing ⚠️
romanisim/wcs.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   92.44%   92.21%   -0.23%     
==========================================
  Files          16       16              
  Lines        1509     1593      +84     
==========================================
+ Hits         1395     1469      +74     
- Misses        114      124      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schlafly schlafly merged commit e6f942f into spacetelescope:main Apr 15, 2024
19 of 21 checks passed
@schlafly schlafly deleted the make-all-detectors branch April 15, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants