Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict size of ActiveSet from types.Ballot #5899

Closed
fasmat opened this issue Apr 29, 2024 · 1 comment
Closed

Restrict size of ActiveSet from types.Ballot #5899

fasmat opened this issue Apr 29, 2024 · 1 comment
Assignees
@fasmat
Labels
technical debt

Comments

@fasmat
Copy link
Member

fasmat commented Apr 29, 2024

Description

The field ActiveSet in types.Ballot isn't actually used anymore. We should restrict its maximum size to 0 (or 1 if zero isn't possible) for backwards compatibility and to keep sizes of future ballots small.

Affected code

See comment #5898 (comment)
@fasmat fasmat self-assigned this Apr 29, 2024
@fasmat fasmat moved this to 🔖 Next in Dev team kanban Apr 29, 2024
@fasmat fasmat mentioned this issue Apr 29, 2024
Merged
4 tasks
@fasmat
Copy link
Member Author

fasmat commented Jul 24, 2024

This has been done in #5965

@fasmat fasmat closed this as completed Jul 24, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Next to ✅ Done in Dev team kanban Jul 24, 2024
@fasmat fasmat removed this from Dev team kanban Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fasmat fasmat

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fasmat