Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade from deprecated importlib.resources function #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

upgrade from deprecated importlib.resources function #26

wants to merge 2 commits into from

Conversation

rtumin2
Copy link

@rtumin2 rtumin2 commented Dec 27, 2023

Fixes #24 by removing the deprecated calls to importlib.resources.path and by fixing a check for whether the build has occurred.

@rtumin2
Copy link
Author

rtumin2 commented Dec 27, 2023

I believe importlib.resources.files is new in python 3.9, so I've updated the requirement and bumped the minor version of the package since this is technically a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests fail on v1.10.1 with FileNotFoundError on msise00_driver
1 participant
@rtumin2