Discovery settings in elasticsearch.yml.erb

[ryan-roemer]

Hi Karel,

Very minor issue, but I hit this in elasticsearch.yml.erb at this section:

<% if node.elasticsearch[:discovery][:type] %>
discovery:
  type: <%= node.elasticsearch[:discovery][:type] %>
<% end %>
<% unless node.elasticsearch[:cloud][:ec2].values.compact.empty? %>
  ec2.groups: <%= node.elasticsearch[:cloud][:ec2][:security_group] %>
<% end %>

I actually have aws settings (and thus node.elasticsearch[:cloud][:ec2]), but I have not yet enabled discovery, which lead to an incorrect YAML directive. I think:

<% if node.elasticsearch[:discovery][:type] %>
discovery:
  type: <%= node.elasticsearch[:discovery][:type] %>
  <% unless node.elasticsearch[:cloud][:ec2].values.compact.empty? %>
  ec2.groups: <%= node.elasticsearch[:cloud][:ec2][:security_group] %>
  <% end %>
<% end %>

might be more appropriate.

[karmi]

Ryan, could you post a (sanitized) data_bags/elasticsearch/aws.json so I understand the issue better?

[ryan-roemer]

Here's an analogue to my data bag (I actually tweaked the attributes to use an encrypted databag):

{
  "id": "elasticsearch",
  "cloud": {
    "ec2": {
      "security_group": "SOMETHING"
    },
    "aws": {
      "secret_key": "SECRET",
      "access_key": "ACCESS"
    }
  }
}

As I do have an ES security group, but am not yet running an ES cluster. This produces a YAML config of:

  ec2.groups: SOMETHING

(without a 0-level indent member discovery) instead of:

discovery:
  type: SOMETHING
  ec2.groups: SOMETHING

which causes a YAML config error.

So, I think it's fair to say you just must have discovery set if you set ec2.groups, but it could be more permissive in case someone sets the cloud.ec2 and not discovery. Totally up to you, and once again -- thanks for the great cookbook and responsiveness to issues!

[karmi]

Hello Ryan,

see f1fc6ef, I think it's fair to use full namespaces in the YAML file, which makes everything more resilient, and the readability does not suffer too much :)

[ryan-roemer]

The full namespaces work well, and don't get in to tortured "if-this-then-that-but-not..." template conditionals. Great idea. Thanks!