Improve environment file formatting #477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the contents of /etc/default/elasticsearch / /etc/sysconfig/elasticsearch more in line with the format that the Elasticsearch package uses. It removes quotes from vars that don't need it, and strips superfluous spaces from ES_JAVA_OPTS for a cleaner look. Tested on Ubuntu 14.04 and CentOS 6.
It also fixes a tiny cosmetic bug that resulted in env_options being included in ES_JAVA_OPTS because the default was '' instead of nil.
Before:
After: