Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway.expected_nodes default should be 0 #399

Closed
jgerry opened this issue Nov 24, 2015 · 3 comments
Closed

gateway.expected_nodes default should be 0 #399

jgerry opened this issue Nov 24, 2015 · 3 comments

Comments

@jgerry
Copy link

jgerry commented Nov 24, 2015

gateway.expected_nodes set to 1 causes indexes that are created in a cluster to be deleted, at least for me. This occurred on both 1.7.3 and 2.0.0. According to the documentation, the default should be zero.

https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-gateway.html

This caused me some mild headaches over the past couple of days but the cookbook has been a fantastic help. Thanks!

@martinb3
Copy link
Contributor

Thanks @jgerry! I confirmed that it defaults to zero in the source repo as well:
https://github.com/elastic/elasticsearch/blob/v2.0.1/distribution/src/main/resources/config/elasticsearch.yml

It looks like the cookbook has set it to 1 for a long time:
https://github.com/elastic/cookbook-elasticsearch/blob/0.3.x/attributes/default.rb#L86

I concur that the default values are probably best. We'll get this out shortly. Thanks again!

@martinb3 martinb3 added this to the 2.0.1 (bugfixing release) milestone Nov 24, 2015
@jgerry
Copy link
Author

jgerry commented Nov 24, 2015

Glad to help! btw the cookbook seems to work fine with 2.1.0 as well, been working on that today. Just adding new sha sums and version attributes, works perfectly.

@martinb3
Copy link
Contributor

martinb3 commented Dec 1, 2015

Thanks @jgerry! Fixing this and the other logging.yml change and will start looking into the ES 2.1.0 support, and then we'll probably push a release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants