Add the defaults for slowlogs in logging.yml

[gmoskovicz]

The default configuration in the main packages contains the default configuration for the slowlogs:

logger:
  # log action execution errors for easier debugging
  action: DEBUG
  # reduce the logging for aws, too much is logged under the default INFO
  com.amazonaws: WARN
  org.apache.http: INFO

  # gateway
  #gateway: DEBUG
  #index.gateway: DEBUG

  # peer shard recovery
  #indices.recovery: DEBUG

  # discovery
  #discovery: TRACE

  index.search.slowlog: TRACE, index_search_slow_log_file
  index.indexing.slowlog: TRACE, index_indexing_slow_log_file

While the slowlogs are configured, they are not enabled by default. The chef recipe should also configure this by default, and then the user should be able to (per index) configure the level and the threadhold.

https://github.com/elastic/cookbook-elasticsearch/blob/master/templates/default/logging.yml.erb

[gmoskovicz]

Once you enable slowlogs without this, the logs will be shipped to the main log file instead to a particular log file, we should add the appender and the following configuration:

  index.search.slowlog: TRACE, index_search_slow_log_file
  index.indexing.slowlog: TRACE, index_indexing_slow_log_file

[gmoskovicz]

@karmi This is the issue that i mentioned before.

Thanks for taking a look!

[gmoskovicz]

@martinb3 IMO we can keep the option to add defaults settings, but the same settings that we ship in the logging.yml should be included here.

Thanks! 😄

[martinb3]

@gmoskovicz at one point @karmi and I even talked about removing it from things we control, so people using Chef can just drop in their own file anyway. Do you think that's more useful than trying to expose every possible option in chef?

[gmoskovicz]

Thats an option too. However if we ship the logging.yml then we should include the exact same configurations that we ship with all our packages to make sure the documentation (in this case how to enable slowlogs) is valid for mostly every package/product.

[martinb3]

However if we ship the logging.yml then we should include the exact same configurations that we ship with all our packages to make sure the documentation (in this case how to enable slowlogs) is valid for mostly every package/product.

👍 I totally agree. I did the same for init scripts, but I didn't think to check the logging.yml :/

[gmoskovicz]

@martinb3 thanks for your prompt response! Looking forward for this change!